Tsee/xs code split #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds src/ subdir to include and c_source properties during build.
Missing: The logic that actually creates the custom OP instances.
This slightly refactors it so that the TCC and keyword-type related logic isn't in it. For now, this seems the cleanest in intent. If a lot of additional logic was added (eg. OPs owning miscellaneous data that would have to be cleaned up at global destruction time), that should be revisited to move that logic into the new source file as well.
|
I think this is a great idea. I'll be tied up for the next couple of days so I may not get to merging this for a little bit. Feel free to continue, or not, as I'll contribute to this as soon as I have some time (maybe this weekend, certainly some time next week). |
|
Something I've always struggled with: do the compiled object files get linked to all compiled xs files? In other words, will this functionality get baked into PerlAPI's shared library? As far as I can tell, this is what Module::Build does by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a start of what I'm musing about in #19
In a nutshell, this moves the custom OP logic to its own source file as well as the executable memory bit.
I think the "extract C code" / parsing logic can/should go into its own thing but I ran out of time and IIRC it's not a clean parser/lexer in the sense that there's actions taken/code being generated on the basis of the parse already there. That makes a bit murky to extract. Anyway - code style preferences I suppose.