Seifa 2021 #105
Merged
Seifa 2021 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peteowen1 given SA codes are stored as characters in |
|
e.g. desired behaviour of: get_seifa(structure = c("lga"),
data_subclass = c("ieo"),
year = NULL) %>%
dplyr::select(1:4) %>%
dplyr::glimpse()
Rows: 548
Columns: 4
$ data_subclass <chr> "ieo", "ieo", "ieo", "ieo", "ieo", "ieo", "ieo", "ieo", …
$ structure <chr> "lga", "lga", "lga", "lga", "lga", "lga", "lga", "lga", …
$ area_code <chr> "10050", "10180", "10250", "10300", "10470", "10500", "1…
$ area_name <chr> "Albury", "Armidale Regional", "Ballina", "Balranald", "…it's just one line to change and i'll add a commit |
|
@wfmackey forgot about this - have updated one line of code to make area_code a character variable |
only mutate area_code if the column exists also change filtering from across to if_any as dplyr guidlines
might as well make all area codes change to character for consistency (now including the sa1_7 and sa1_11 columns) also filter out if code and/or name is null, not just code
filter works best to remove row unless it has a code and a name (this helps remove the © Commonwealth of Australia 2023 row)
|
Hi all, Will this be merged in the future? Looks like it should be good to go, no? |
wfmackey
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included summary tables in get_seifa, with data_subclass = 'summary'.
Added the data_subclass as a column name to avoid confusion about which row is which when multiple subclasses are chosen, like current output shown below:
Added year as a column name - again to avoid confusion.
Treat hyphens as missing in the spreadsheets so that score columns get read in as numeric class instead of character.