reduce threshold for fuzzy matching in clean_state() #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfmackey
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #111
clean_state()has an argumentmax_dist. A higher value permits 'fuzzier' matches, a lower value requires stricter matches.This PR changes the default value of
max_distfrom 0.4 to 0.2. This will reduce spurious matches (as documented in the issue #111 ) at the potential cost of more failed 'true matches'. In my view this trade-off is worth it, and testing suggests this will not be a significant issue. Users remain able to manually specifymax_distif they do not want to accept the default value.