Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(website): upgrade vuepress 1.x to 2.x #2980

Merged
merged 21 commits into from
Jan 18, 2023

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jan 13, 2023

what

  • Upgrade vuepress to 2.x
  • Use docsearchPlugin plugin for algolia
  • add internalizationation (i18n)
  • Allow renaming some files to Overview as we do in our current docs (unsure if this is possible)
  • Fix home page to allow scrolling down to see benefits
  • Convert stylus to scss for Home.vue

Should we

  • set contributors to false ?
    • sometimes it shows duplicate names
  • set lastUpdated to false ?
    • it shows some pages haven't been updated in years which doesn't look the best

why

  • Latest and greatest
  • v1 is no longer supported
  • Resolve all security issues in website
  • Dark mode is supported

tests

  • I have tested my changes by running yarn install && yarn website:dev locally
✗ yarn audit
yarn audit v1.22.19
0 vulnerabilities found - Packages audited: 240
✨  Done in 0.69s.
yarn run vuepress dev runatlantis.io --debug

references

@nitrocode nitrocode requested a review from a team as a code owner January 13, 2023 04:54
@nitrocode nitrocode marked this pull request as draft January 13, 2023 05:04
@nitrocode nitrocode force-pushed the vuepress-upgrade branch 3 times, most recently from c8d4c3a to 350d65b Compare January 13, 2023 05:24
@nitrocode nitrocode changed the title Upgrade vuepress to 2.x chore(deps): website: upgrade vuepress 1.x to 2.x Jan 13, 2023
@nitrocode nitrocode marked this pull request as ready for review January 13, 2023 16:44
@nitrocode nitrocode enabled auto-merge (squash) January 13, 2023 20:25
@nitrocode nitrocode marked this pull request as draft January 13, 2023 22:07
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Looks great after turning the lights on. :D

@nitrocode nitrocode merged commit b248299 into runatlantis:main Jan 18, 2023
@nitrocode nitrocode deleted the vuepress-upgrade branch January 18, 2023 22:08
@chenrui333 chenrui333 changed the title chore(deps): website: upgrade vuepress 1.x to 2.x deps(website): upgrade vuepress 1.x to 2.x Jan 18, 2023
@nitrocode nitrocode added this to the v0.22.3 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies PRs that update a dependency file website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants