Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase version requirement of vm module to v3.2 #170

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

cblkwell
Copy link
Contributor

@cblkwell cblkwell commented Nov 4, 2024

what

This bumps the version requirements on the vm module so that it is compatible with v6 of the google provider. Unfortunately, due to the fact that the IAP enabled setting is required for v6 of the google_compute_backend_service resource (and is not in v5), this will make it incompatible with v5 of the provider.

why

Currently, it's impossible to use the v6 version of the provider because v3.1 of the vm module requires a provider version below 6.

references

@cblkwell cblkwell requested a review from a team as a code owner November 4, 2024 15:00
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 4, 2024
@cblkwell cblkwell changed the title Loosen vm module ver Increase version requirement of vm module to v3.2 Nov 4, 2024
@cblkwell cblkwell force-pushed the loosen-vm-module-ver branch 2 times, most recently from 8f0a2a3 to 5eff943 Compare November 4, 2024 15:22
@d-costa
Copy link
Collaborator

d-costa commented Nov 6, 2024

hey @cblkwell how are you?
If you fix the doc I can approve this 👍

docker run --rm --volume "$(pwd):/terraform-docs" -u $(id -u) quay.io/terraform-docs/terraform-docs:0.17.0 markdown --output-file README.md --output-mode inject /terraform-docs

@cblkwell cblkwell force-pushed the loosen-vm-module-ver branch from 9ab65db to db0ccce Compare November 7, 2024 14:40
@cblkwell
Copy link
Contributor Author

cblkwell commented Nov 7, 2024

Okay, I think we're all sorted now.

@cblkwell cblkwell merged commit db94072 into runatlantis:main Nov 7, 2024
5 checks passed
@cblkwell cblkwell deleted the loosen-vm-module-ver branch November 7, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants