Improve job wait #162
Open
Improve job wait #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
job-wait, I realized that the plugin has a bug in output logs. It shows logs twice and this is confusing for the end user. Since IMHO the issue was the approach I did a total refactor ofjob-waitand submit a PR that can be useful for other people.In my approach the executor follows the job, taking care of backoff retry and trying to "attach" to a running job that is already failed and is in a retry phase.
I'm a DevOps and not a developer so I'm not up to writing tests, but I see that only a little portion of the code is tested.