Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forbidden errors when token is about to expire #38

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Fix forbidden errors when token is about to expire #38

merged 2 commits into from
Nov 19, 2021

Commits on Nov 18, 2021

  1. Fixed documentation of open and read timeout form ms -> s

    @anrock-sc
    anrock-sc committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    adc8ab5 View commit details
    Browse the repository at this point in the history

  2. Aquire new token if current token is about to expire 

    This fixes the edge case when the communication to vault is very slow
and the passed token is about to expire, it can happen that
the call to lookup self returns success but the following vault calls
still run into an error as the token just expired.

This change will fix this by calculating the maximal time, a call to
vault will take. This is capped to 60 seconds as the documentation
for the read and open timeout parameters were wrong. As the previous
documentation stated that the timout paramter are ms valued, they
are actually seconds. This could cause users to have high values
in these paramters. To prevent continues token refreshing in that case,
the maximal guaranteed token validity is capped to 60 seconds.
    @anrock-sc
    anrock-sc committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    a5d91dd View commit details
    Browse the repository at this point in the history