This repository has been archived by the owner on Mar 27, 2020. It is now read-only.
Fix #6 Authentication test incorrectly uses POST after redirect #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #6, this error occurs only when authenticating with user/password and when the Rundeck host is wrong (IP adresses or "localhost" if hostname is defined).
The fix consits of restarting the authentication sequence if the real Rundeck hostname is different when receiving a HTTP redirect 302 in response of an authentication POST. Because the JSESSIONID cookie is lost if the hostname change during the authentication redirect sequence (debugged with Wireshark).
This fix has been tested successfully with Rundeck Monitor using login/password authentication and IP address instead of Rundeck server host.