Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option url parameters #152

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

b0tting
Copy link

@b0tting b0tting commented Nov 4, 2024

This is a PR to add the new parameters for URL based options (basic auth, regex, bearer token etcetera) and solve #144. I suggest using a second level block to group these parameters and prevent clutter in the docs and code. There is no additional validation, ie. you could select basic authentication and add a bearer token at the moment.

@fdevans This code is not working at this time. I think the issue is in jobFromResourceData(:846) with the JobValueChoicesURL object not being a map of strings. My knowledge of Go is very limited and I could not find another component with a similar setup. I hope my groundwork is enough to finish this with little extra effort. If not, feel free to delete this pull request.

@fdevans
Copy link
Contributor

fdevans commented Nov 4, 2024

Thanks for the headstart. Hopefully some other members of the community can help improve on the work you've started here. I'll likely do another round of reviews and merges in a few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants