Skip to content

Update pvp-performance-tracker to v1.7.0 #8077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Matsyir
Copy link
Contributor

@Matsyir Matsyir commented May 23, 2025

Yet another new statistic! Along with various improvements and fixes.

The new statistic "hits on robes", it tracks how many times you were hit by melee/range while in robes. You don't want to get hit in robes. You can configure if this looks at only robe bottom, top, both, or either.
Screenshot 2025-05-23 185915

Also added a very basic new Frame/Window to display a summary of all the attacks used, in a more concise way than the fight log.
Screenshot 2025-05-23 185259

Mostly changes from these PRs, many thanks to the contributors! More details in regards to the various improvements/fixes can be found in the PRs.

Matsyir/pvp-performance-tracker#54
Matsyir/pvp-performance-tracker#55
Matsyir/pvp-performance-tracker#56

@runelite-github-app
Copy link

runelite-github-app bot commented May 23, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented May 23, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@Matsyir
Copy link
Contributor Author

Matsyir commented May 24, 2025

I will re-open this soon, hold merge for now, another commit for minor fixes/improvements coming

I tried and failed to rebase this branch/PR to make it 1 commit instead of 2, idk how to do it without deleting the branch and re-making the PR. If it's a significant issue lmk and will do

In this last commit, since the initial PR, only some minor changes: I mostly made some tooltip improvements/clarifications, moved the ghost barrage statistic to be the last/bottom-most one (it's rarely relevant), and deleted the 'copy as discord msg' feature, since it wasn't kept up to date, and everyone already uses screenshots anyways.

@Matsyir Matsyir closed this May 24, 2025
@Matsyir Matsyir reopened this May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant