Skip to content

Add bingosrs plugin #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mistereman22
Copy link

This plugin is for use alongside the BingOSRS website: https://bingosrs.com/.

It will grab data on required drops from the server based on user configuration (bingo ID), and then listen for drops and submit a screenshot along with drop data when the player receives one of the required drops.

@runelite-github-app
Copy link

@runelite-github-app
Copy link

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@cdfisher
Copy link
Contributor

Have you considered collaborating with the authors of any of the existing bingo and/or Discord webhook plugins? There are already a lot of those on the hub, and (just based on your description as I haven't looked at the plugin code) at least a large subset of your functionality is already stuff that's doable with something like Dink.

@mistereman22
Copy link
Author

Have you considered collaborating with the authors of any of the existing bingo and/or Discord webhook plugins? There are already a lot of those on the hub, and (just based on your description as I haven't looked at the plugin code) at least a large subset of your functionality is already stuff that's doable with something like Dink.

I looked into utilizing Dink but it doesn't easily fit the use case for a couple reasons, I haven't fully looked into all discord webhook plugins but the ones I have are similar:

  • Lack of support for custom data models.
  • Lack of support for arbitrary item lists.

I think both of these can be rigged up to work in base Dink (using dynamic config url and modifying the API endpoints to accept the payload that Dink sends) but requires the user to set fields that are not necessarily intuitive to non-developers. Also (maybe more importantly), this plugin currently only supports submitting drops, but the intention is that it will support other functionality (e.g. displaying bingo information) in the future that falls outside the scope of what Dink does.

As for existing bingo plugins, https://github.com/bingoscape/bingoscape-companion is the most similar, but I don't think there's enough overlap to warrant cramming both into a single plugin.

Right now, this plugin does duplicate some logic from Dink for identifying drops from different events (e.g. ServerNpcLoot, NpcLootReceived, LootReceived). From my perspective, an ideal solution would have that logic output available to consume in my plugin. I hadn't looked at any plugin code prior to a week ago though, so I'm likely missing a lot of context too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants