Skip to content

Ajout du plugin Ti-Kai la mitraille #8084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Steevvy
Copy link

@Steevvy Steevvy commented May 24, 2025

Ce plugin joue des sons personnalisés lors de certains événements comme les trades, drops de familiers, mort, prière vide, etc. Les fichiers .wav sont embarqués dans le .jar.

@runelite-github-app
Copy link

runelite-github-app bot commented May 24, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented May 24, 2025

Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Contributor

riktenx commented May 25, 2025

Re-stating my comment from your previous PR--

The actual functionality in this plugin seems to be covered by several other existing ones on the hub such as watchdog. We'd rather not have duplicates. If those plugins are missing features you're looking for then we'd prefer you contribute to them instead.

@LlemonDuck
Copy link
Contributor

Nous avons déjà beaucoup de plugins que joue des sons (comme watchdog). Nous préfèrons vous utiliser ceux-là.


Nécessaires:

  • échangez log.info contre log.debug
  • utlisez AudioPlayer pour jouer des sons

Aussi, si vous pouvez communiquer Anglais, nous le préfèrons.

@Steevvy
Copy link
Author

Steevvy commented May 25, 2025

Totally understand your decision — thank you for the feedback.

My intention wasn't to duplicate existing functionality, but rather to have my own set of personalized sound cues to better distinguish specific drops and events during gameplay.

I’ll explore whether contributing to existing plugins like Watchdog makes sense for those needs, or rethink how I can bring something more unique.

Appreciate the review and all the work you do on RuneLite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants