Update chance-man to 2.2.0 #8088
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Implement NPC drop table viewer in music tab
This commit introduces a major UI feature that allows players to view NPC drop tables directly in-game by temporarily hijacking the music tab interface.
A "Show Drops" menu option has been added to the right-click menu for NPCs. When selected, the plugin fetches the NPC's drop data and dynamically replaces the content of the music tab with a custom drop viewer UI.
The new UI consists of several components:
- **`DropsTabUI`**: The main class that initializes and manages the lifecycle of this feature.
- **`DropsMenuListener`**: Injects the "Show Drops" option into the NPC context menu.
- **`MusicWidgetController`**: The core of the feature, responsible for:
- Backing up and hiding the original music widget elements.
- Drawing a new interface that displays the NPC's name, level, and a progress bar for rolled vs. total drops.
- Creating a scrollable grid of all possible drop items, with items the player has already "rolled" appearing faded.
- **`SpriteOverrideManager`**: Replaces the default music tab icon with a custom "drops" icon to indicate that the drop viewer is active.
- **`TabListener`**: Detects when the player navigates away from the music tab and restores its original content, ensuring the drop viewer is temporary.
- **`WidgetUtils`**: Provides helper functions for creating menu entries and managing widget children.
Fix dependency injection for Gson and OkHttpClient; add DropFetcher shutdown
Fix dependency injection for Gson and OkHttpClient; add DropFetcher shutdown
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
- Replace manual name-and-ID search fallback with MediaWiki’s Special:Lookup extension (always queries by npcId first, then falls back to the provided name) - Simplify `buildWikiUrl` to emit `/w/Special:Lookup?type=npc&id=<npcId>&name=<fallback>#Drops` - Remove `findTitleByNpcId` and obsolete two-stage lookup logic - Streamline `fetch()` to log the Special:Lookup URL, fetch HTML, and parse drop tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Implement NPC drop table viewer in music tab
This commit introduces a major UI feature that allows players to view NPC drop tables directly in-game by temporarily hijacking the music tab interface.
A "Show Drops" menu option has been added to the right-click menu for NPCs. When selected, the plugin fetches the NPC's drop data and dynamically replaces the content of the music tab with a custom drop viewer UI.
The new UI consists of several components:
DropsTabUI: The main class that initializes and manages the lifecycle of this feature.DropsMenuListener: Injects the "Show Drops" option into the NPC context menu.MusicWidgetController: The core of the feature, responsible for:SpriteOverrideManager: Replaces the default music tab icon with a custom "drops" icon to indicate that the drop viewer is active.TabListener: Detects when the player navigates away from the music tab and restores its original content, ensuring the drop viewer is temporary.WidgetUtils: Provides helper functions for creating menu entries and managing widget children.