Skip to content

Added the GogglesReminder plugin #8099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Noatel
Copy link

@Noatel Noatel commented May 26, 2025

So recently a friend of mine, created a ton of potions but later messaged me that he forgot his goggles after days of grinding it. This plugin prevents that, after creating a couple potions, a message (in red) pops up in chat saying "Don't forget your Prescription Goggles!".

image

@runelite-github-app
Copy link

runelite-github-app bot commented May 26, 2025

@Noatel Noatel closed this May 26, 2025
@Noatel Noatel reopened this May 26, 2025
@runelite-github-app
Copy link

runelite-github-app bot commented May 26, 2025

Internal use only: Reviewer details Maintainer details

@tylerwgrass
Copy link
Member

  • Your icon file should be at the root of your repo, named icon.png and no larger than 48x72px.
  • Please delete the config file if you aren't using it yet. If you choose to add options in the future you can re-add it.
  • This looks like its going to trigger on any herblore xp (e.g. cleaning herbs) and not just potions which doesn't really make sense.

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label May 27, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 29, 2025
@Noatel
Copy link
Author

Noatel commented May 29, 2025

Hey! Thanks for you feedback

  • I have changed the image and put it into the root file
  • Deleted the config file
  • Changed the logica to work only for potions based on the set i made in the class PotionItemIds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants