[Bug] JS exception in DrawingManager.SetMap #206

rungwiroon · Aug 27, 2022 · 4731625 · 4731625
1 parent 80a9c58
commit 4731625
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 13 deletions.
diff --git a/GoogleMapsComponents/GoogleMapsComponents.csproj b/GoogleMapsComponents/GoogleMapsComponents.csproj
@@ -18,7 +18,7 @@
 		<RazorLangVersion>3.0</RazorLangVersion>
 		<AddRazorSupportForMvc>true</AddRazorSupportForMvc>
 		<PackageId>BlazorGoogleMaps</PackageId>
-		<Version>2.2.4</Version>
+		<Version>2.2.5</Version>
 		<Authors>Rungwiroon</Authors>
 		<Company>QueueStack Solution</Company>
 		<Product>BlazorGoogleMaps</Product>

diff --git a/GoogleMapsComponents/Maps/Drawing/DrawingManager.cs b/GoogleMapsComponents/Maps/Drawing/DrawingManager.cs
@@ -77,12 +77,13 @@ public Task SetDrawingMode(OverlayType? drawingMode)
 
         /// <summary>
         /// Attaches the DrawingManager object to the specified Map.
+        /// https://developers.google.com/maps/documentation/javascript/reference/drawing#DrawingManager.setMap
         /// </summary>
         /// <param name="map"></param>
         public async Task SetMap(Map map)
         {
             await _jsObjectRef.InvokeAsync(
-                   "googleMapDrawingManagerJsFunctions.setMap",
+                   "setMap",
                    map);
 
             _map = map;

diff --git a/ServerSideDemo/Pages/DrawingManagerPage.razor b/ServerSideDemo/Pages/DrawingManagerPage.razor
@@ -6,4 +6,5 @@
 <GoogleMap @ref="@map1" Id="map1" Options="@mapOptions" OnAfterInit="@(async () => await OnAfterInitAsync())"></GoogleMap>
 <button @onclick="ChangeDrawingModeToLine">Change mode to line</button>
 <button @onclick="StopDrawingMode">Stop drawing mode</button>
+<button @onclick="SetMap">Set Map</button>
 @*<div id="map" @ref="@map1ElementRef" style="height: 450px"></div>*@
diff --git a/ServerSideDemo/Pages/DrawingManagerPage.razor.cs b/ServerSideDemo/Pages/DrawingManagerPage.razor.cs
@@ -10,9 +10,9 @@ namespace ServerSideDemo.Pages
 {
     public partial class DrawingManagerPage
     {
-        private DrawingManager drawingManager;
-        private DrawingManagerOptions managerOptions;
-        private PolygonOptions polygonOptions;
+        private DrawingManager _drawingManager;
+        private DrawingManagerOptions _managerOptions;
+        private PolygonOptions _polygonOptions;
         private GoogleMap map1;
         private MapOptions mapOptions;
 
@@ -33,7 +33,7 @@ protected override void OnInitialized()
                 DisableDefaultUI = true
             };
 
-            polygonOptions = new PolygonOptions()
+            _polygonOptions = new PolygonOptions()
             {
                 StrokeWeight = 1,
                 FillOpacity = 0.45f,
@@ -58,19 +58,19 @@ private async Task OnAfterInitAsync()
                 DrawingModes = overlayTypes
             };
 
-            managerOptions = new DrawingManagerOptions()
+            _managerOptions = new DrawingManagerOptions()
             {
                 Map = map1.InteropObject,
-                PolygonOptions = polygonOptions,
+                PolygonOptions = _polygonOptions,
                 //DrawingMode = OverlayType.Polygon,
                 DrawingControl = true,
                 DrawingControlOptions = drawingControlOptions
             };
 
-            drawingManager = await DrawingManager.CreateAsync(JsRuntime, managerOptions);
+            _drawingManager = await DrawingManager.CreateAsync(JsRuntime, _managerOptions);
 
             //https://developers.google.com/maps/documentation/javascript/drawinglayer
-            await drawingManager.AddOverlayCompleteListener(async (overComplete) =>
+            await _drawingManager.AddOverlayCompleteListener(async (overComplete) =>
             {
                 if (overComplete.Type == OverlayType.Polygon)
                 {
@@ -91,14 +91,19 @@ await poly.SetOptions(new PolygonOptions()
 
         private async Task ChangeDrawingModeToLine()
         {
-            await drawingManager.SetDrawingMode(OverlayType.Polyline);
+            await _drawingManager.SetDrawingMode(OverlayType.Polyline);
 
         }
 
         private async Task StopDrawingMode()
         {
-            await drawingManager.SetDrawingMode(null);
+            await _drawingManager.SetDrawingMode(null);
 
         }
+
+        private Task SetMap()
+        {
+            return _drawingManager.SetMap(_drawingManager.GetMap());
+        }
     }
 }
diff --git a/ServerSideDemo/Pages/GMap.razor.cs b/ServerSideDemo/Pages/GMap.razor.cs
@@ -1,4 +1,5 @@
-using System.Threading.Tasks;
+using System;
+using System.Threading.Tasks;
 using GoogleMapsComponents.Maps;
 using Microsoft.AspNetCore.Components;