Skip to content

Conversation

@bluematter
Copy link

Motivation

I want to pass in a number of outputs into comfy and get the same amount of outputs sent back in the API

Issues closed

#95

# Redis configuration from environment variables
REDIS_HOST = os.environ.get("REDIS_HOST", "localhost")
REDIS_PORT = int(os.environ.get("REDIS_PORT", 6379))
r = redis.Redis(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you hard code like this ?

REDIS_HOST = os.environ.get("REDIS_HOST", "localhost")
REDIS_PORT = int(os.environ.get("REDIS_PORT", 6379))
r = redis.Redis(
host='redis-13524.fcrce180.us-east-1-1.ec2.redns.redis-cloud.com',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with ENV variable pls

@TimPietrusky
Copy link
Contributor

TimPietrusky commented Apr 23, 2025

@bluematter thanks for putting the effort into this PR.

it looks to me that you not only added support for multiple images, but also a lot more (like redis and loras and more). would you mind to clarify everything you have done here, so that we can do a proper review?

@Andergraw
Copy link

Hey guys, thank you all for the great work. @bluematter wouldn't it be easier to just fix the batch loading separately and then add the other features sequentially?
Thanks!

@TimPietrusky
Copy link
Contributor

@bluematter @Andergraw @khengyun we have added support for multiple output images in #118, is that what you wanted? because multiple input-images are already possible

@Andergraw
Copy link

@bluematter @Andergraw @khengyun we have added support for multiple output images in #118, is that what you wanted? because multiple input-images are already possible

This exactly what I wanted, thanks! How is it done? Using the batch input from Empty Latent node? Can It be done with runsync endpoint?
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants