-
Notifications
You must be signed in to change notification settings - Fork 549
fix: allow to process multiple images #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| # Redis configuration from environment variables | ||
| REDIS_HOST = os.environ.get("REDIS_HOST", "localhost") | ||
| REDIS_PORT = int(os.environ.get("REDIS_PORT", 6379)) | ||
| r = redis.Redis( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you hard code like this ?
| REDIS_HOST = os.environ.get("REDIS_HOST", "localhost") | ||
| REDIS_PORT = int(os.environ.get("REDIS_PORT", 6379)) | ||
| r = redis.Redis( | ||
| host='redis-13524.fcrce180.us-east-1-1.ec2.redns.redis-cloud.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace with ENV variable pls
|
@bluematter thanks for putting the effort into this PR. it looks to me that you not only added support for multiple images, but also a lot more (like redis and loras and more). would you mind to clarify everything you have done here, so that we can do a proper review? |
|
Hey guys, thank you all for the great work. @bluematter wouldn't it be easier to just fix the batch loading separately and then add the other features sequentially? |
|
@bluematter @Andergraw @khengyun we have added support for multiple output images in #118, is that what you wanted? because multiple input-images are already possible |
This exactly what I wanted, thanks! How is it done? Using the batch input from Empty Latent node? Can It be done with runsync endpoint? |
Motivation
I want to pass in a number of outputs into comfy and get the same amount of outputs sent back in the API
Issues closed
#95