Make default fallback reasons more explicit, fix comment

runtimeverification · Jul 24, 2024 · 8c943d3 · 8c943d3
1 parent 9c82e4e
commit 8c943d3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/booster/tools/booster/Proxy.hs b/booster/tools/booster/Proxy.hs
@@ -351,7 +351,7 @@ respondEither cfg@ProxyConfig{boosterState} booster kore req = case req of
                                     <$> accumulatedLogs
                                 )
                                 r{ExecuteRequest.state = execStateToKoreJson simplifiedBoosterState}
-                -- if we stop for a reason in fallbackReasons (default [Aborted, Stuck, Branching],
+                -- if we stop for a reason in fallbackReasons (default [Aborted, Stuck],
                 -- revert to the old backend to re-confirm and possibly proceed
                 | boosterResult.reason `elem` cfg.fallbackReasons -> do
                     Booster.Log.withContext CtxProxy $

diff --git a/booster/tools/booster/Server.hs b/booster/tools/booster/Server.hs
@@ -450,7 +450,7 @@ clProxyOptionsParser =
                 (eitherReader $ mapM reasonReader . splitOn ",")
                 ( long "fallback-on"
                     <> metavar "REASON1,REASON2..."
-                    <> value [Stuck, Aborted]
+                    <> value defaultFallbackReasons
                     <> help "Halt reasons for which requests should be re-executed with kore-rpc"
                     <> showDefaultWith (intercalate "," . map show)
                 )
@@ -466,6 +466,8 @@ clProxyOptionsParser =
                 ( long "no-fallback-simplify"
                     <> help "disable simplification before fallback requests"
                 )
+    defaultFallbackReasons :: [HaltReason]
+    defaultFallbackReasons = [Stuck, Aborted]
 
     reasonReader :: String -> Either String HaltReason
     reasonReader = \case