3888 typed context and parser #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
commented
Jun 20, 2024
|
|
||
| withPatternContext :: LoggerMIO m => Pattern -> m a -> m a | ||
| withPatternContext Pattern{term, constraints} m = | ||
| let t' = foldl' AndTerm term $ Set.toList $ Set.map coerce constraints | ||
| let t' = foldl' AndTerm term $ Set.toList $ Set.map coerce constraints -- FIXME |
There was a problem hiding this comment.
I noticed this earlier while trying to copy/paste a KoreJson pattern from a log into a file for custom requests.
- The output does not have the correct sort (we would need to introduce
#Equals{SortBool, <sort-of-term>}(true, _)around the predicates) - That would mean we cannot use
AndTermany more
We should probably go toKoreJsonfirst (externalise the pattern) for the output, but then we need to come up with a stable hash for logging purposes
There was a problem hiding this comment.
Does it cause issues when internalising? I.e. when you copy/pasted KoreJson from a log line and tried to send that to the server it reported an error?
There was a problem hiding this comment.
The server rejects the predicates having a wrong sort IIRC, but I would have to re-try this to be sure.
jberthold
force-pushed
the
3888-typed-context-and-parser
branch
from
ec5ccf3 to
bcef5c3
Compare
geo2a
approved these changes
Jun 20, 2024
| @@ -230,7 +230,7 @@ main = do | |||
| kore@KoreServer{runSMT} <- | |||
| mkKoreServer Log.LoggerEnv{logAction} clOPts koreSolverOptions | |||
| runBoosterLogger $ | |||
| Booster.Log.withContext "proxy" $ | |||
| Booster.Log.withContext CtxKore $ | |||
goodlyrottenapple
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
count-abortsto parse the json data using the new type. Performance is on par after switching to TH-derivedFromJSONinstances.Conversion of
kore-rpclogging is left for future work.Part of #3888