Jb/trim booster ground truth #4038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now, the substitution parameter is always emtpy at the call sites of `checkPredicates`, but we filter the substitution equations anyway. The helper functions are made local, they can be promoted later if need be.
|
KEVM test perfomance appears unchanged (this change probably only pays off for larger proofs)
|
geo2a
approved these changes
Aug 21, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
boosterchecks predicates with a given ground truth (a substitution and other predicates assumed true), this change filters the substitution and the ground truth to only contain predicates using relevant variables (from the predicates to check, and transitively from other relevant predicates).