Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only markSimplified when we are sure the predicate is in fact simplified #4049

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

goodlyrottenapple
Copy link
Member

Kore is currently is crashing for @bbyalcinkaya in komet, with:

CallStack (from HasCallStack):
  error, called at src/Kore/Internal/Predicate.hs:1091:5 in kore-0.1.76-9jTVMLO4n9YCl9sOQx8AFb:Kore.Internal.Predicate
  cannotSimplifyNotSimplifiedError, called at src/Kore/Internal/Predicate.hs:1120:36 in kore-0.1.76-9jTVMLO4n9YCl9sOQx8AFb:Kore.Internal.Predicate
  checkedSimplifiedFromChildren, called at src/Kore/Internal/Predicate.hs:1130:14 in kore-0.1.76-9jTVMLO4n9YCl9sOQx8AFb:Kore.Internal.Predicate
  markSimplified, called at src/Kore/Simplify/Not.hs:152:17 in kore-0.1.76-9jTVMLO4n9YCl9sOQx8AFb:Kore.Simplify.Not","error":"Unexpectedly marking term with NotSimplified children as simplified:
...

@goodlyrottenapple
Copy link
Member Author

No change in KEVM

@goodlyrottenapple goodlyrottenapple marked this pull request as ready for review September 13, 2024 17:15
@jberthold
Copy link
Member

Maybe still good to investigate this a bit more before we swallow the unexpected condition...
There was a bug report supplied on slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants