Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix match_with_constraint #4499

Draft
wants to merge 10 commits into
base: develop
Choose a base branch
from
Draft

Fix match_with_constraint #4499

wants to merge 10 commits into from

Conversation

tothtamas28
Copy link
Contributor

@tothtamas28 tothtamas28 commented Jul 4, 2024 •
edited
Loading

Fixes #4496

@rv-jenkins rv-jenkins changed the base branch from master to develop July 4, 2024 09:10
tothtamas28
tothtamas28 commented Jul 4, 2024
View reviewed changes
Copy link
Contributor Author

@tothtamas28 tothtamas28 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CTerm.constraint seems to have two different uses.

pyk/src/pyk/cterm/cterm.py Outdated Show resolved Hide resolved
pyk/src/pyk/cterm/cterm.py Outdated Show resolved Hide resolved
@tothtamas28 tothtamas28 mentioned this pull request Jul 4, 2024
Open
@tothtamas28 tothtamas28 linked an issue Jul 4, 2024 that may be closed by this pull request
CTerm.match_with_constraint does not return expected CSubst.constraints #4496
Open
@Stevengre Stevengre mentioned this pull request Jul 5, 2024
Open
@Stevengre Stevengre mentioned this pull request Jul 15, 2024
Closed
@Stevengre Stevengre force-pushed the fix-cterm-match branch 4 times, most recently from b7c5bff to d5bcbd2 Compare August 20, 2024 09:00
@Stevengre Stevengre mentioned this pull request Sep 5, 2024
Merged
@Stevengre Stevengre force-pushed the fix-cterm-match branch 2 times, most recently from ec7162c to 4fa4e82 Compare September 20, 2024 01:52
@Stevengre
Copy link
Contributor

Since #4628 determines the apply in CSubst and provides a cterm_match that aligns with this apply, we can proceed to fix match_with_constraint using cterm_match.

@Stevengre
Copy link
Contributor

Downstream Validation:

Other Repos

No direct use.

CTerm.match

The following check carries some risk because match_with_constraint conducts a syntactic match and does not return an evaluated constraint. However, it is still an improvement over the original implementation, which always returns true when provided with a tighter cterm.

k/pyk/src/pyk/cterm/cterm.py

Lines 158 to 159 in 4fa4e82

if csubst.constraint != mlTop(GENERATED_TOP_CELL):
return None

Cterm.anti_unify

Return a correct constraint.

KCFG.create_cover

Return a correct constraint.

KCFG.lift_split_edge

Need Refactor

KCFG.lift_split_split

Need Refactor

KCFG.merge_node

Need Simplify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetarMax PetarMax PetarMax left review comments

@Stevengre Stevengre Stevengre left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Stevengre Stevengre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTerm.match_with_constraint does not return expected CSubst.constraints
3 participants
@tothtamas28 @Stevengre @PetarMax