Include keccak & aux lemmas conditionally #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palinatolmach
requested review from
anvacaru and
PetarMax
and removed request for
PetarMax and
anvacaru
palinatolmach
commented
Aug 16, 2024
palinatolmach
changed the title
--no-keccak-lemmas option
anvacaru
approved these changes
Aug 21, 2024
anvacaru
reviewed
Aug 21, 2024
|
Something's off with some integration tests but it doesn't happen locally — I'll try to re-run both in CI and locally too. |
|
It seems to take too long, the task... perhaps it is better to not include by default, and include only on demand? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #715.
Partially addresses #780.
This PR
keccak.mdfile containing (unsound) assumptions about keccak to facilitate reasoning, use it by defaultkontrol_lemmas.mdfile containing other Kontrol lemmas that facilitate reasoning (copied from Morpho lemmas with the exclusion of keccak assumptions included inkeccak.md)kontrol buildby default--no-keccak-lemmas,--auxiliary-lemmasoptions tokontrol buildwhich excludes and includes keccak and auxiliary lemmas, respectively"provided")