Option --extra-module for including lemmas modules dynamically in kontrol prove
#883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra module to Prover
…ng extra lemmas at prove time
| extra_lemmas_module = single(module for module in modules.modules if module.name == extra_module_name) | ||
| non_rule_sentences = [sent for sent in extra_lemmas_module.sentences if not isinstance(sent, KRule)] | ||
| if non_rule_sentences: | ||
| raise ValueError(f'Supplie --extra-module contains non-Rule sentences: {non_rule_sentences}') |
There was a problem hiding this comment.
Suggested change
| raise ValueError(f'Supplie --extra-module contains non-Rule sentences: {non_rule_sentences}') | |
| raise ValueError(f'Supplied --extra-module contains non-Rule sentences: {non_rule_sentences}') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: runtimeverification/k#4681
Blocked on: runtimeverification/evm-semantics#2654
Part of: #149
This adds an option to
kontrol provecalled--extra-module <FILE_NAME>:<MODULE_NAME>which allow specifying an extra file with a module that contains new lemmas to be included in the proof context dynamically.This will allow a user to, for example, remove a node corresponding to a spurious branch and re-run through that node with an additional body of lemmas to see if that body of lemmas allows pruning the branch without rebuilding the whole project.
Currently, this does add something like 40s to prove time to parse the additional module, which I guess is better than the overhead associated with
kontrol build ...anyway.