-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cheatcodes that generate symbolic variables with custom names #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetarMax
reviewed
Dec 5, 2024
PetarMax
reviewed
Dec 5, 2024
palinatolmach
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Slightly late to the party - it would be great if we could make a minor adjustment where the indices are not separated from the name, like the backend has been doing for a while now - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
custom_step
to rename symbolic variables generated by cheatcodes.Blocked on :
runtimeverification/kontrol-cheatcodes#16In this PR:
#rename
rule that all cheatcodes that generate symbolic variables would rewrite into.The goal is to have a single cut-rule
rename
.2. In
KontrolSemantics
, we add:_check_rename_pattern(self, cterm: CTerm) -> bool
:#rename
cut-rule is at the top of the K Cell._exec_rename_custom_step(self, cterm: CTerm) -> KCFGExtendResult | None
:target_var
) and new name (new_name
) from the top of the K Rule.Subst
replaces all instances of thetarget_var
with a newKVariable(new_name.token, target_var.sort)
in the givenCTerm
configuration and constraints.kontrol-cheatcodes
andforge-std
versions fortests/integration/test-data/foundry