Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowCalls cheatcode #926

Merged
merged 49 commits into from
Jan 28, 2025
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
6305559
Draft for the `allowCalls` implementation
palinatolmach Jan 8, 2025
6f33d53
Make `AllowedCallCellMap` empty in init cterm
palinatolmach Jan 10, 2025
f4a75d7
`allowedCallsList` refactoring, add `allowedAllCalls`
palinatolmach Jan 10, 2025
2d0f9ef
Merge branch 'master' into allow-calls-cheatcode
palinatolmach Jan 13, 2025
5c47b68
Add new rule, K cell pattern
palinatolmach Jan 13, 2025
248e7c0
Merge branch 'master' into allow-calls-cheatcode
palinatolmach Jan 14, 2025
fcc15d9
Merge branch 'master' into allow-calls-cheatcode
palinatolmach Jan 16, 2025
759caeb
Add list simplifications
palinatolmach Jan 16, 2025
50bf832
Adjust and add tests for `allowCalls`
palinatolmach Jan 16, 2025
7e5e33b
Add tests for `allowCalls` to end-to-end tests
palinatolmach Jan 16, 2025
bff0810
Update expected output in `end-to-end` tests
palinatolmach Jan 16, 2025
001cf55
Remove fixed `kontrol-cheatcodes` version
palinatolmach Jan 16, 2025
e5ab34b
Removed a TODO comment
palinatolmach Jan 16, 2025
a4ad642
`cheatcodes.md` cleanup
palinatolmach Jan 16, 2025
eb4b118
Remove `ADDRESSLIST_CELL`
palinatolmach Jan 16, 2025
5a32c70
`AllowChangesTest` cleanup
palinatolmach Jan 16, 2025
7918983
Another output update
palinatolmach Jan 16, 2025
f5a8b12
Update expected output
palinatolmach Jan 16, 2025
3181d14
Update CSE expected output
palinatolmach Jan 16, 2025
2ffc75d
Update `trace` tests output
palinatolmach Jan 16, 2025
0c4380b
Use `auxiliary_lemmas` in end-to-end tests
palinatolmach Jan 16, 2025
bef331a
Output update for `RandomVarTest`
palinatolmach Jan 16, 2025
232ec94
Enable `auxiliary_lemmas` in `build` instead of `prove`
palinatolmach Jan 16, 2025
c9cce21
Merge branch 'master' into allow-calls-cheatcode
palinatolmach Jan 16, 2025
c7d2bab
Change `testFailAllowCalls_ifNotWhitelisted` signature
palinatolmach Jan 16, 2025
376146c
Remove `expectRevert` from failing test
palinatolmach Jan 16, 2025
b758ee0
Apply review suggestion
palinatolmach Jan 16, 2025
a9fae41
Another output update for `RandomVarTest`
palinatolmach Jan 16, 2025
7a09749
Reduce `end-to-end` parallel processes to 6
palinatolmach Jan 17, 2025
33d6eb5
update expected output
anvacaru Jan 17, 2025
c412328
Apply `CallToAddress` review suggestion
palinatolmach Jan 17, 2025
ab78122
Use `.Bytes` to represent all calls being allowed
palinatolmach Jan 17, 2025
0eeb826
Another output update for `RandomVarTest.test_custom_names`
palinatolmach Jan 17, 2025
a533c8b
Experiment: add `--force-sequential` to end-to-end tests
palinatolmach Jan 19, 2025
44cc1dc
Reduce num processes in the update-output job to 4
palinatolmach Jan 19, 2025
bc8c5f9
Update `RandomVarTest.test_custom_names`
palinatolmach Jan 19, 2025
e8b1db5
update expected output
anvacaru Jan 20, 2025
63ee68e
Merge branch 'master' into allow-calls-cheatcode
anvacaru Jan 20, 2025
2c03441
see full diff in ci
anvacaru Jan 21, 2025
5fbe1cc
show diff in ci
anvacaru Jan 21, 2025
313c960
Merge branch 'master' into allow-calls-cheatcode
anvacaru Jan 28, 2025
19e4e71
update expected output
anvacaru Jan 28, 2025
c40c885
Merge branch 'master' into allow-calls-cheatcode
palinatolmach Jan 28, 2025
1bf3d19
Change Solidity version in `AllowChangesTest`
palinatolmach Jan 28, 2025
778b942
Add `end-to-end` tests to the output update workflow
palinatolmach Jan 28, 2025
bee1df2
Update Solidity versions in `allow` tests
palinatolmach Jan 28, 2025
8f95787
Bring back source maps for tests with expected output
palinatolmach Jan 28, 2025
73d51b1
Address review comments
palinatolmach Jan 28, 2025
f97f21a
Merge branch 'master' into allow-calls-cheatcode
palinatolmach Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update expected output
palinatolmach committed Jan 16, 2025
commit f5a8b1248b67f1c2cef5ebca5642700db7e8ab47
Original file line number Diff line number Diff line change
@@ -251,12 +251,12 @@ module SUMMARY-TEST%ASSERTTEST.CHECKFAIL-ASSERT-FALSE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -493,12 +493,12 @@ module SUMMARY-TEST%ASSERTTEST.CHECKFAIL-ASSERT-FALSE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -734,12 +734,12 @@ module SUMMARY-TEST%ASSERTTEST.CHECKFAIL-ASSERT-FALSE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -977,12 +977,12 @@ module SUMMARY-TEST%ASSERTTEST.CHECKFAIL-ASSERT-FALSE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -1220,12 +1220,12 @@ module SUMMARY-TEST%ASSERTTEST.CHECKFAIL-ASSERT-FALSE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
Original file line number Diff line number Diff line change
@@ -251,12 +251,12 @@ Node 10:
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -497,12 +497,12 @@ module SUMMARY-TEST%ASSERTTEST.TESTFAIL-ASSERT-TRUE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -739,12 +739,12 @@ module SUMMARY-TEST%ASSERTTEST.TESTFAIL-ASSERT-TRUE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -980,12 +980,12 @@ module SUMMARY-TEST%ASSERTTEST.TESTFAIL-ASSERT-TRUE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -1223,12 +1223,12 @@ module SUMMARY-TEST%ASSERTTEST.TESTFAIL-ASSERT-TRUE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
@@ -1466,12 +1466,12 @@ module SUMMARY-TEST%ASSERTTEST.TESTFAIL-ASSERT-TRUE():0
<isCallWhitelistActive>
false
</isCallWhitelistActive>
<allowedCallsList>
.List
</allowedCallsList>
<isStorageWhitelistActive>
false
</isStorageWhitelistActive>
<addressList>
.List
</addressList>
<storageSlotList>
.List
</storageSlotList>
Loading