fix ordinals not being applied to return types of symbols

lib/ast/definition.cpp

@@ -172,6 +172,45 @@ SymbolMap kore_definition::get_overloads() const {
   return transitive_closure(overloads);
 }
 
+static void process_sort_ordinal(
+    kore_sort *sort,
+    std::unordered_map<kore_composite_sort, uint32_t, hash_sort> &sorts,
+    std::vector<kore_composite_sort *> &all_sorts, uint32_t &next_sort) {
+  // We use a work list to ensure that parametric sorts get ordinals
+  // that are greater than the ordinals of any of their parameters.
+  // This invariant is usefull for serialization purposes, and given
+  // that all parametric sorts are statically known, it is sound to
+  // assign ordinals to them in such a topological order.
+  std::stack<std::pair<kore_composite_sort *, bool>> worklist;
+  auto *ctr = dynamic_cast<kore_composite_sort *>(sort);
+  worklist.push(std::make_pair(ctr, false));
+
+  while (!worklist.empty()) {
+    auto *sort_to_process = worklist.top().first;
+    bool params_processed = worklist.top().second;
+    worklist.pop();
+
+    if (!sorts.contains(*sort_to_process)) {
+      if (!params_processed) {
+        // Defer processing this sort until its parameter sorts have
+        // been processed.
+        worklist.push(std::make_pair(sort_to_process, true));
+        for (auto const &param_sort : sort_to_process->get_arguments()) {
+          auto *param_ctr
+              = dynamic_cast<kore_composite_sort *>(param_sort.get());
+          worklist.push(std::make_pair(param_ctr, false));
+        }
+        continue;
+      }
+
+      sorts.emplace(*sort_to_process, next_sort++);
+      all_sorts.push_back(sort_to_process);
+    }
+
+    sort_to_process->set_ordinal(sorts[*sort_to_process]);
+  }
+}
+
 // NOLINTNEXTLINE(*-function-cognitive-complexity)
 void kore_definition::preprocess() {
   get_subsorts();
@@ -286,40 +325,11 @@ void kore_definition::preprocess() {
     for (auto *symbol : entry.second) {
       if (symbol->is_concrete()) {
         for (auto const &sort : symbol->get_arguments()) {
-          // We use a work list to ensure that parametric sorts get ordinals
-          // that are greater than the ordinals of any of their parameters.
-          // This invariant is usefull for serialization purposes, and given
-          // that all parametric sorts are statically known, it is sound to
-          // assign ordinals to them in such a topological order.
-          std::stack<std::pair<kore_composite_sort *, bool>> worklist;
-          auto *ctr = dynamic_cast<kore_composite_sort *>(sort.get());
-          worklist.push(std::make_pair(ctr, false));
-
-          while (!worklist.empty()) {
-            auto *sort_to_process = worklist.top().first;
-            bool params_processed = worklist.top().second;
-            worklist.pop();
-
-            if (!sorts.contains(*sort_to_process)) {
-              if (!params_processed) {
-                // Defer processing this sort until its parameter sorts have
-                // been processed.
-                worklist.push(std::make_pair(sort_to_process, true));
-                for (auto const &param_sort :
-                     sort_to_process->get_arguments()) {
-                  auto *param_ctr
-                      = dynamic_cast<kore_composite_sort *>(param_sort.get());
-                  worklist.push(std::make_pair(param_ctr, false));
-                }
-                continue;
-              }
-
-              sorts.emplace(*sort_to_process, next_sort++);
-              all_sorts_.push_back(sort_to_process);
-            }
-
-            sort_to_process->set_ordinal(sorts[*sort_to_process]);
-          }
+          process_sort_ordinal(sort.get(), sorts, all_sorts_, next_sort);
+        }
+        if (symbol->get_sort()->is_concrete()) {
+          process_sort_ordinal(
+              symbol->get_sort().get(), sorts, all_sorts_, next_sort);
         }
         if (!instantiations.contains(*symbol)) {
           instantiations.emplace(*symbol, next_symbol++);