New allocation algorithm #1166
Merged
New allocation algorithm #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenmeker
force-pushed
the
new_alloc
branch
from
59be401 to
9a72c6e
Compare
…rent_block_ptr and collection_block_ptr; added initialization for data members
…n; moved some inline functions from arena.cpp to arena.h; make struct memory_block_header in a union; fix comments
…(); fix for move_ptr()
stevenmeker
force-pushed
the
new_alloc
branch
from
f89f156 to
a75b285
Compare
dwightguth
approved these changes
Dec 5, 2024
theo25
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
This looks good to me.
Just to make sure I understand correctly, could you confirm if the following is accurate: In this new allocation algorithm, we have only one memory block header at the start of the hyperblock, as opposed to the previous algorithm that had one header per smaller block. This is the reason for the change in the calculation for arena size. Also, we still compute the equivalent of the number of small blocks in the new algorithm to inform GC triggering decisions.
|
That is correct. I tried to simulate the old GC triggering algorithm, however note that allocations > 1 MB are now accommodated in the GC'd arena. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced algorithm in class arena with one that uses mmap()'d address spaces and demand paging for each semispace and initializes the current semispace of each arena at start time to avoid and the second semispace of each arena at swap time to avoid relying on Undefined Behavior or having an extra test in kore_arena_alloc().