Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add relevant info for MacOS building process #1176

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Add relevant info for MacOS building process #1176

merged 4 commits into from
Dec 9, 2024

Conversation

Robertorosmaninho
Copy link
Collaborator

No description provided.

@Robertorosmaninho Robertorosmaninho self-assigned this Dec 5, 2024
@rv-jenkins rv-jenkins changed the base branch from master to develop December 5, 2024 22:00
theo25
theo25 reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@theo25 theo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had to install libffi with homebrew. Did you not have to do that in your fresh instance of macos?

INSTALL.md Outdated Show resolved Hide resolved
@Robertorosmaninho
Copy link
Collaborator Author

Robertorosmaninho commented Dec 5, 2024 •
edited
Loading

I also had to install libffi with homebrew. Did you not have to do that in your fresh instance of macos?

I haven't tested it in a fresh instance yet, but this is related to the SDK issue I mentioned earlier today in our meeting.

On my personal macOS, libffi was found under macOS15's SDK:

Found FFI: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.1.sdk/usr/lib/libffi.tbd

@theo25 theo25 self-requested a review December 5, 2024 22:20
theo25
theo25 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@theo25 theo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Make sure you check my one suggestion for a typo.

@automergerpr-permission-manager automergerpr-permission-manager bot merged commit c362cf0 into develop Dec 9, 2024
10 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the update-install-docs branch December 9, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theo25 theo25 theo25 approved these changes

@dwightguth dwightguth Awaiting requested review from dwightguth

Assignees

@Robertorosmaninho Robertorosmaninho

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robertorosmaninho @theo25