Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a templated release workflow to run on manual dispatch, for no… #21

Closed
wants to merge 12 commits into from

Conversation

F-WRunTime
Copy link
Member

In Relation to https://github.com/runtimeverification/devops/issues/108

Adding template for release workflow only with manual deploy execution for python packages

Documentation followed for workflow recommendation by Pypi

@tothtamas28
Copy link
Collaborator

@F-WRunTime did you test this?

@Baltoli
Copy link
Contributor

Baltoli commented Apr 12, 2023

Looks sensible but I will let @tothtamas28 approve - thanks @F-WRunTime!

@F-WRunTime
Copy link
Member Author

F-WRunTime commented Oct 13, 2023

@F-WRunTime did you test this?

I did not realize the workflows and cookiercutter work the way they do. Did some reading and trying to test at least a simple release workflow here that publishes to pypi test. We'll see how this goes. I'm still learning poetry. I am not quite sure I have the release.yml setup such that it best mimics what we'd want to use in our other repository release steps.

Simply trying

poetry build 
poetry publish

@F-WRunTime
Copy link
Member Author

F-WRunTime commented Oct 13, 2023

Testing Release is here -- running into some lint check type issues...

Used Trusted Publishing > Need to configure Release environment in GH repository and in Pypi account for this to work properly and is unique for every repository publishing here out of our ORG.
Good top level is noted here in this action on how to use the general action and pypi links.

Notes on setting up a trusted repository in Pypi
Keep trying tomorrow...

@tothtamas28
Copy link
Collaborator

I think this shouldn't be part of the Python template (similar discussion from earlier: #8 (comment)). As a first step, we could add this to the master-push.yml of some of our Python projects, then figure out a way to reuse our typical CI scripts (with cookiecutter template, repo template, or even better, a library of custom actions).

@F-WRunTime F-WRunTime closed this Oct 13, 2023
@F-WRunTime F-WRunTime deleted the feature/release-publish-workflow branch October 13, 2023 17:59
@F-WRunTime
Copy link
Member Author

I think this shouldn't be part of the Python template (similar discussion from earlier: #8 (comment)). As a first step, we could add this to the master-push.yml of some of our Python projects, then figure out a way to reuse our typical CI scripts (with cookiecutter template, repo template, or even better, a library of custom actions).

Okay. Thanks for the reminder. I will go back and review and conversation. Sounds like we should focus on a more generic approach. I will target methods to work for PYk and K pygments to see what I can do with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants