Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrc20 balance fixes #310

Merged
merged 31 commits into from
Apr 28, 2020
Merged

Wrc20 balance fixes #310

merged 31 commits into from
Apr 28, 2020

Conversation

hjorthjort
Copy link
Contributor

Misc fixes, mostly necessary for verifying $do-balance in KEwasm

@hjorthjort hjorthjort requested review from ehildenb and removed request for ehildenb April 16, 2020 12:20
@hjorthjort hjorthjort marked this pull request as draft April 16, 2020 12:20
kwasm-lemmas.md Outdated Show resolved Hide resolved
@hjorthjort hjorthjort marked this pull request as ready for review April 16, 2020 15:48
@hjorthjort hjorthjort requested a review from ehildenb April 17, 2020 10:53
@ehildenb
Copy link
Member

Some of these lemmas appear to make the term bigger, which always makes me skeptical. But I don't want to hold this up.

@hjorthjort
Copy link
Contributor Author

Some of these lemmas appear to make the term bigger, which always makes me skeptical. But I don't want to hold this up.

I agree in general, but I think it's alright as long as they are only in a specialized module, like WRC20-LEMMAS. Because they are aimed at that specific program and they work well there.

@ehildenb
Copy link
Member

@hjorthjort FYI, once automerge is applied, and it's approved, and tests are passing, you don't need to manually merge it into master. In some cases it will make it merge sooner to do so, but on the average doing so will just increase the build pressure on our servers.

@hjorthjort
Copy link
Contributor Author

hjorthjort commented Apr 21, 2020 via email

@ehildenb ehildenb self-requested a review April 22, 2020 13:24
@hjorthjort
Copy link
Contributor Author

Can you make sense of this error? Seems all the tests ran into it:

Cannot contact rvwork-2: java.lang.InterruptedException

@hjorthjort
Copy link
Contributor Author

hjorthjort commented Apr 23, 2020

Also, the conformance tests all got this error, but it seems it didn't stop them:

error: object directory /home/jenkins-slave/devops.git/objects does not exist; check .git/objects/info/alternates.

@ehildenb
Copy link
Member

@hjorthjort the first error just means rvwork-2 went offline for a bit, so you just need to force rebuild.

The second error usually shows up if the Jenkinsfile or Makefile does any git operations. It usually is harmless. It's because we have a server-wide git-cache running, but the cache is not available once you've finished the checkout scm step which actually checks out the code on Jenkins. So any use of git commands in the repo itself will have problems with that step.

@hjorthjort
Copy link
Contributor Author

Not sure automerge is getting the hint here.

@hjorthjort hjorthjort merged commit 75baf9b into master Apr 28, 2020
@hjorthjort hjorthjort deleted the wrc20-balance-fixes branch April 28, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants