Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hamburger and chevron icons for sidebar toggle on mobile devices #2586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HAMZA-NASIR-PU
Copy link

Changes proposed

This PR introduces a hamburger icon and a chevron icon for toggling the sidebar specifically on mobile devices.

Key Changes:

  1. Added a hamburger icon to open the sidebar.
  2. Added a chevron icon for closing the sidebar.
  3. Ensured the functionality works smoothly on mobile devices, improving the user experience.
  4. Tested for responsiveness and compatibility.

Screenshots

Screenshot 1
Screenshot 2

Screenshot 3
Screenshot  4

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2024 8:36pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We would suggest that you close this PR and implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@rupali-codes
Copy link
Owner

Hey thanks @HAMZA-NASIR-PU, do we have any closing issue for it?

@HAMZA-NASIR-PU
Copy link
Author

@rupali-codes

There is no closing issue for this task, but based on my review of the app, I noticed that adding a hamburger and chevron icon for toggling the sidebar on mobile devices would significantly enhance the user experience.

@rupali-codes
Copy link
Owner

@rupali-codes

There is no closing issue for this task, but based on my review of the app, I noticed that adding a hamburger and chevron icon for toggling the sidebar on mobile devices would significantly enhance the user experience.

Alright, but from next time onwards, please make sure to raise an issue before working on anything.

And, could you please change the hamburger icon color from white to gray as per the theme?
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants