add generic ping test

See GH #17

Changes

@@ -1,5 +1,17 @@
 CHANGES
 -------
+2.75  2021-02-22 11:08:05 rurban
+      Bugfixes
+      - Fixed wrong link to p5p message (jamieletual PR #25)
+      Test fixes:
+      - Disable all network tests with NO_NETWORK_TESTING=1 (Petr Písař PR #24)
+      - Use non-routable addresses for negative tests (Petr Písař PR #24)
+      - Remove some TEST_REQUIRES modules (Chris Williams PR #23)
+      - Fixed TEST_REQUIRES for older EUMM
+      - Added a test that ping on an unresolvable hostname does not croak,
+        just warns. (See GH #17)
+      - Added tests that named args override defaults (See GH #26)
+
 2.74  2020-09-09 09:21:39 rurban
       Features
       - Add ICMPv6_NI_REPLY support.

MANIFEST

@@ -19,6 +19,7 @@ t/140_stream_inst.t
 t/150_syn_inst.t
 t/190_alarm.t
 t/200_ping_tcp.t
+t/201_ping.t
 t/250_ping_hires.t
 t/300_ping_stream.t
 t/400_ping_syn.t

t/001_new.t

@@ -27,24 +27,28 @@ isa_ok($p3, "Net::Ping");
 eval {
     $p = Net::Ping->new("thwackkk");
 };
-like($@, qr/Protocol for ping must be "icmp", "icmpv6", "udp", "tcp", "syn", "stream" or "external"/, "new() errors for invalid protocol");
+like($@, qr/Protocol for ping must be "icmp", "icmpv6", "udp", "tcp", "syn", "stream" or "external"/,
+     "new() errors for invalid protocol");
 
 # check for invalid timeout
 eval {
     $p = Net::Ping->new("tcp", -1);
 };
-like($@, qr/Default timeout for ping must be greater than 0 seconds/, "new() errors for invalid timeout");
+like($@, qr/Default timeout for ping must be greater than 0 seconds/,
+     "new() errors for invalid timeout");
 
 # check for invalid data sizes
 eval {
     $p = Net::Ping->new("udp", 10, -1);
 };
-like($@, qr/Data for ping must be from/, "new() errors for invalid data size");
+like($@, qr/Data for ping must be from/,
+     "new() errors for invalid data size");
 
 eval {
     $p = Net::Ping->new("udp", 10, 70000);
 };
-like($@, qr/Data for ping must be from/, "new() errors for invalid data size");
+like($@, qr/Data for ping must be from/,
+     "new() errors for invalid data size");
 
 # force failures for udp
 
@@ -70,4 +74,3 @@ SKIP: {
     $p = Net::Ping->new("icmp", undef, undef, undef, "does this fail");
     isa_ok($p, "Net::Ping");
 }
-

t/201_ping.t

@@ -0,0 +1,43 @@
+use strict;
+
+BEGIN {
+  if ($ENV{NO_NETWORK_TESTING} ||
+      ($ENV{PERL_CORE}) && !$ENV{PERL_TEST_Net_Ping}) {
+    print "1..0 # Skip: network dependent test\n";
+    exit;
+  }
+  unless (eval "require Socket") {
+    print "1..0 \# Skip: no Socket\n";
+    exit;
+  }
+  unless (getservbyname('echo', 'tcp')) {
+    print "1..0 \# Skip: no echo port\n";
+    exit;
+  }
+}
+
+# Hopefully this is never a routeable host
+my $fail_ip = $ENV{NET_PING_FAIL_IP} || "192.0.2.0";
+my $fail_host = 'invalid-hostname.xxxx';
+
+# Remote network test using defaults.
+#
+# NOTE:
+#   Network connectivity will be required for all tests to pass.
+#   Firewalls may also cause some tests to fail, so test it
+#   on a clear network.
+
+use Test::More tests => 4;
+BEGIN {use_ok('Net::Ping');}
+
+my $p = Net::Ping->new();
+isa_ok($p, 'Net::Ping', 'new() worked');
+
+# failing host lookup does not croak
+if ($p->ping($fail_host)) {
+  ok (1, "SKIP $fail_host unexpectedly resolved");
+} else {
+  ok (1, "$fail_host returns undef");
+}
+
+is($p->ping($fail_ip), 0, "Can't reach $fail_ip");