acknack optional subscription params #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also re-factored assertBack to be sendHook. Naming was too vague.
Added new functionality to validate inbound frames (outbound ones are assumed to be ok as we are constructing/testing them) and associated tests Added unsubscribe support Made existing tests a bit more robust (using process.nextTick for net stream simulation)
Added inbound frame validation support + tests Swapped sys for util throughout the code Mocked util.log for tests to suppress output Better setup/teardowns on tests
…nd moved example into example dir
…on disconnect(). All registered error callbacks get called on reception of ERROR frames. Also removed unnecessary callback in subscribe() method signature.
Build badges
Bump for the licence change in the package file
check whether if stream error before write
update README adding vhost on Stomp constructor documentation
tls parameter added to constructor, can be boolean or options to tls module. Constructor overloaded to accept options object in addition to positional parameters. Removed SecureStompClient as it relied on obsolete stream.setSecure method.
Add TLS support for secure connections.
emit 'message' event on message
Fix to call connect callback when connection complete on TLS connection.
…t, does not add the content-length header. also added unit test
…n always true, fixed.
…eader-and-unit-test Adds support for 'suppress-content-length' header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get an error when "subscription" is undefined :
Unexpected ACK received for message-id [ID:1f1f40b6881b-43489-1644697490837-5:1924:-1:1:3]
Keep a "subscription" optionnel and it's working