fix: build for macOS #431
Merged
fix: build for macOS #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9030421145Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
sjackman
reviewed
Jul 8, 2024
| @@ -21,7 +21,7 @@ bio-types = ">=0.9" | |||
| byteorder = "1.3" | |||
| custom_derive = "0.1" | |||
| derive-new = "0.5" | |||
| hts-sys = {version = "2.1.1", default-features = false} | |||
| hts-sys = {version = "2.1.4", default-features = false, features = ["bindgen"]} | |||
There was a problem hiding this comment.
Was this an intentional change that bindgen changed from an optional dependency to a required dependency of rust-htslib?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For getting the CI running on
aarch64-apple-darwinrunners hts-sys needs to be updated due to an issue caused by bindgen. This has been fixed in the latesthts-sysrelease (see rust-bio/hts-sys#10).