Address all TODO in v20
#284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamillambert
force-pushed
the
0704-v20-TODOs
branch
from
bf93d77 to
f6209da
Compare
tcharding
reviewed
Jul 7, 2025
|
|
||
| /// Implements Bitcoin Core JSON-RPC API method `generatetodescriptor` | ||
| #[macro_export] | ||
| macro_rules! impl_client_v17__generate_to_descriptor { |
There was a problem hiding this comment.
In 38b6fe9
cut'n'pasta error here mate, should be v20
tcharding
reviewed
Jul 7, 2025
|
Reviewed f6209da |
jamillambert
force-pushed
the
0704-v20-TODOs
branch
from
f6209da to
7a48f15
Compare
|
Rebased, only change is fixing the v17 to v20 name. |
Add the RPC `generatetodescriptor` type to v20 and add reexports. Add model, into function, client macro and test. Update types table up to v29, v23 and later don't have docs for `Generating` and therefore no table entry.
`createmultisig` said TODO for v20 onwards. It has been done as part of another PR adding missing fields. Remove the TODO.
`signmessagewithprivkey` was marked as TODO because it has a return filed name change in v20 and up. But the struct has a single unnamed field so no changes are needed. Remove the TODO.
`validateaddress` was marked as TODO in v20 and up. But there are no changes up to v29. Remove the TODO.
jamillambert
force-pushed
the
0704-v20-TODOs
branch
from
7a48f15 to
aa91a26
Compare
tcharding
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go through all the
TODOin v20 types. NB. v17 to v19 are all done already.Add the new RPC
generatetodescriptor.Other 3 RPCs require no further action, remove the
TODOwith the reason stated in the commit log.