add scanblocks call #317
add scanblocks call #317
Conversation
| /// Start a scan of the block filter index for an [output descriptor](https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md). | ||
| pub struct ScanBlocksRequest<'a> { | ||
| /// List of descriptors to scan | ||
| pub scanobjects: &'a [ScanBlocksRequestDescriptor], |
There was a problem hiding this comment.
Maybe scanobjects can be a Vec<ScanBlocksRequestDescriptor> (since ScanBlocksRequestDescriptor already owns its descriptor), then we could do away with the lifetime 'a.
Can possibly also derive Default for this whole struct.
There was a problem hiding this comment.
Pretty much just copied this from another json array example in the file
rust-bitcoincore-rpc/json/src/lib.rs
Line 1190 in 23927f3
Is this giving you issues and did you test it your way? I seem to remember testing it with a Vec and having issues.
There was a problem hiding this comment.
If you want to make a PR into my branch with how you're doing it I'm happy to merge it into my branch
There was a problem hiding this comment.
no, no issue. I think I tried it both ways.
No description provided.