Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minreq_http feature of jsonrpc #341

Merged
merged 1 commit into from
May 14, 2024

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented May 1, 2024

Recently in jsonrpc we added an HTTP client that uses minreq. Since we now use a version of jsonrpc with this feature we can now use minreq here.

@tcharding
Copy link
Member Author

Replaces #259

@tcharding tcharding added this to the v0.19.0 milestone May 1, 2024
@tcharding tcharding force-pushed the 05-01-use-minreq branch from 3526412 to e47a803 Compare May 1, 2024 02:28
@tcharding tcharding force-pushed the 05-01-use-minreq branch from e47a803 to bc32cfc Compare May 1, 2024 03:05
@tcharding tcharding force-pushed the 05-01-use-minreq branch 2 times, most recently from bec1295 to d066a48 Compare May 13, 2024 22:14
Recently in `jsonrpc` we added an HTTP client that uses `minreq`. Since
we now use a version of `jsonrpc` with this feature we can now use
`minreq` here.
@tcharding tcharding marked this pull request as ready for review May 14, 2024 21:23
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 93e9af8

@apoelstra apoelstra merged commit 7fefd90 into rust-bitcoin:master May 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants