-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/fix: add new Client
builder method with an arbitrary timeout value & add new method for scantxoutset status
#365
base: master
Are you sure you want to change the base?
Conversation
Client
builder method with an arbitrary timeout valueClient
builder method with an arbitrary timeout value
Concept ACK In the past I've worked around this by building a custom client (see e.g. #211 (comment)). Having the option to do this directly from rust-bitcoincore-rpc would be nice. |
Client
builder method with an arbitrary timeout valueClient
builder method with an arbitrary timeout value & add new method for scantxoutset status
Client
builder method with an arbitrary timeout value & add new method for scantxoutset statusClient
builder method with an arbitrary timeout value & add new method for scantxoutset status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 8e8790f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry didn't mean to re-review this. @tcharding can you kick off the workflow so the tests run?
CI was all green when I read your post above but I re-ran all tests for you as well. |
Yeah, I kicked it a few hours ahead of you :). |
Thanks guys for kicking off the build, all checks passing. This is a pretty straight forward change, anything else you think it needs to be ready to merge? This is required for a new feature @luisschwab is working on for BDK to allow a wallet to sync with a pruned bitcoind node. |
I personally have completely given up on this repo, I don't know if or when @stevenroose will merge and/or release. |
@tcharding if @stevenroose is up for it maybe can add write access for a BDK dev or two? This crate is one of our upstream dependencies so we'd like to help keep it up-to-date. |
Steven doesn't check GitHub notifications very often, you'll have more luck if you reach him on Signal or some other method. I would suggest that you would have more success if you:
(2) may require some effort but would likely be better in the long run IMO, that crate is in progress though, if you give me a list of the JSONRPC methods you guys use I can prioritise them. I'm actively hacking on it. |
This PR fixes #361 by creating a new buider method for
Client
, namelynew_with_custom_timeout()
, that adds a newtimeout
parameter relative tonew()
.This was done mainly to allow RPCs that take longer than 15 seconds as defined in the
rust-jsonrpc
crate.It's up to the user to define a sensible timeout value.