Automated daily update to rustc (to nightly-2025-10-31) #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
725eced to
8cad60b
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
8cad60b to
20c6961
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
20c6961 to
f50142c
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
f50142c to
84a6c84
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
84a6c84 to
b249e61
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
b249e61 to
5534ae6
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
5534ae6 to
8314285
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
8314285 to
a3f449e
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
a3f449e to
4fd65dd
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
4fd65dd to
8a055e2
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
8a055e2 to
6d75a3f
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
6d75a3f to
3acfbc6
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
3acfbc6 to
a2e231e
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
a2e231e to
ece7100
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
ece7100 to
81d8e47
Compare
apoelstra
changed the title
apoelstra
changed the title
apoelstra
added a commit
to apoelstra/rust-miniscript
that referenced
this pull request
Sep 9, 2025
apoelstra
added a commit
to apoelstra/rust-miniscript
that referenced
this pull request
Sep 9, 2025
apoelstra
added a commit
to apoelstra/rust-miniscript
that referenced
this pull request
Sep 9, 2025
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
fc484aa to
e487b07
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
e487b07 to
a6f2e27
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
a6f2e27 to
9f59bec
Compare
apoelstra
changed the title
apoelstra
added a commit
that referenced
this pull request
Sep 28, 2025
…dling and sortedmulti b5db340 sortedmulti: take Thresh as input to constructors (Andrew Poelstra) 276cf94 sortedmulti: simplify constructor and improve unit test (Andrew Poelstra) 3250e40 miniscript: take pubkey size into account in multi() type extdata (Andrew Poelstra) 8874640 miniscript: fix ExtData to correctly account for uncompressed keys (Andrew Poelstra) 040c29d miniscript: remove MalleablePkH script context rule (Andrew Poelstra) a5c477b clippy: fix all nightly lints (Andrew Poelstra) Pull request description: Removes the weird and incorrect `MalleablePkH` script context rule; fixes several bugs related to key size estimation in pkh and multisig fragments; improves tests of sortedmulti; uses the `Thresh` type in sortedmulti constructors. These bugs are obscure and only visible when using uncompressed pubkeys and I don't think they're worth backporting. This PR is starting to make "real" changes toward unifying our validation parameters. In particular we separate out validation errors in the `sortedmulti` constructors from threshold-construction errors (which the user is forced to deal with before calling a `sortedmulti` constructor). The PR is bigger than you might think because when testing this separation I found some bugs. This PR also includes a clippy fix which should unstick #805 (update nightly version) which has been stalled for months because the weekly retries don't trigger Github notifications and I didn't notice it. ACKs for top commit: sanket1729: utACK b5db340 Tree-SHA512: 4c221f4efe1014001d4bbb99fd89728f5b56348c09d34df9163ff01766cd11e5d13834ecb3bc7ceb49ae89a99d6149587d83b0d901f2b73c64cc91c9a47684fc
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
9f59bec to
ee60c5b
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
ee60c5b to
1473ee9
Compare
apoelstra
changed the title
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
1473ee9 to
c505faa
Compare
|
Oh we actually need to fix the docs.rs thing before release |
|
Oh, no, it's in bitcoin-io, not here. We will need to fix this upstream. cc @tcharding can we release a bitcoin-io 0.1.4 with the doc thing removed? |
|
Done in rust-bitcoin/rust-bitcoin#5183 |
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
c505faa to
f38ed96
Compare
apoelstra
changed the title
apoelstra
force-pushed
the
create-pull-request/daily-nightly-update
branch
from
f38ed96 to
48cc1d2
Compare
apoelstra
changed the title
tcharding
added a commit
to tcharding/rust-miniscript
that referenced
this pull request
Nov 3, 2025
We cannot link to a file by directory path in rustdocs. Just remove the link. This is breaking the docs build in rust-bitcoin#805 and is also mentioned in rust-bitcoin#872.
Merged
apoelstra
added a commit
that referenced
this pull request
Nov 3, 2025
f853906 Remove link to doc file (Tobin C. Harding) Pull request description: We cannot link to a file by directory path in rustdocs. Just remove the link. This is breaking the docs build in #805 and is also mentioned in #872. ACKs for top commit: apoelstra: ACK f853906; successfully ran local tests Tree-SHA512: d2e2eb182cb823297de53635ac23d55ff920b750d28efa7e18de08ddeda3a7f2bdffe8ff32dcf4c54ec32a33a176cea349291260388fd5e5cdad14c6c2e9802e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated update to Github CI workflow
rust.ymlby create-pull-request GitHub action