Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example for directly modifying pixels on mode 3 realtime during game vs loading a pixel array directly. #188

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

EvanTheProgrammer
Copy link
Contributor

No description provided.

@Lokathor
Copy link
Member

This looks good, and having your own credit on the file is totally fine, but before I can merge it I would need you to add it under the same license as the rest of the code in the repo (Zlib OR Apache-2.0 OR MIT), for simplicity to users of the crate. Documentation and config files and other non-code files can be CC0 on occasion, but I'd like all code files to have an identical license.

@EvanTheProgrammer
Copy link
Contributor Author

I have updated to MIT licence

@Lokathor
Copy link
Member

Oh, sorry that I was unclear. The OR parts mean that the crate is currently available under any of the three licenses and the user accepting the code gets to pick. So you'd have to contribute the file under the full three-license-choice thing. Just like it says in the license file of this repo's Cargo.toml.

More simply: you can remove the mention of any particular license from the file and then the file would default to being under the same license as the rest of the repository under GitHub's TOS for how contributions work.

@EvanTheProgrammer
Copy link
Contributor Author

I have removed the licence part.

@Lokathor Lokathor merged commit a2d760d into rust-console:main Nov 16, 2023
1 check passed
@EvanTheProgrammer EvanTheProgrammer deleted the mode3_realtime_example branch November 16, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants