clothed functions #197

Lokathor · 2024-08-27T01:35:10Z

This removes the use of naked functions, because they can be replaced with global assembly (it's just slightly less readable), and naked functions aren't on track for any sort of swift stabilization.

This isn't intended to meaningfully break much, but you'll have to adjust your imports.

TODO:

???

…y stuff, we want precise functions.

…s that we need to go back to IRQ mode (not SVC mode) when finishing up the IRQ handler (which should have been obvious).

Anders429

Loving the efforts to get off of unstable Rust. Everything mostly looks good to me in this change. I believe the changes to the initialization logic and the IRQ handling logic are functionally equivalent to what they were before this change.

examples/game_vblank_draw.rs

src/div_fns.bak

src/macros.rs

src/div_fns.bak

… those operations in the lib.

…port for now, compiler-builtins still provides it.

Lokathor added 12 commits August 26, 2024 19:22

clothed functions

d072c78

remove the asm_runtime module as a public module

1578771

partly fix the examples.

ec4104a

add RUST_IRQ_HANDLER to the prelude

f316e66

make the crate work right with both a32 and t32 building.

7713faf

fix incorrect mgba logging activation.

4fca81d

it all builds but there's bugs in here.

20f0981

we had the wrong number of copies.

9626d18

we can delete the old stuff we don't even want all that general memcp…

3397603

…y stuff, we want precise functions.

try putting the irq handler in iwram to speed it up

73d1dde

get the correct runtime handler code from the 0.12 branch; the bug wa…

aa656a5

…s that we need to go back to IRQ mode (not SVC mode) when finishing up the IRQ handler (which should have been obvious).

skip flipping dy when bouncing off of a paddle in the pong demo.

5c11ad0

Anders429 reviewed Aug 28, 2024

View reviewed changes

examples/game_vblank_draw.rs Outdated Show resolved Hide resolved

src/div_fns.bak Outdated Show resolved Hide resolved

src/macros.rs Outdated Show resolved Hide resolved

src/div_fns.bak Outdated Show resolved Hide resolved

Lokathor self-assigned this Aug 28, 2024

Lokathor added 7 commits September 1, 2024 20:25

remove excess imports

20e7516

remove unsafe code usage from examples by providing safe wrappers for…

d180fa6

… those operations in the lib.

make the pointer type match the usage.

dd6e9cc

i'm just going with not having the crate provide special division sup…

8bfa518

…port for now, compiler-builtins still provides it.

fix the pointer type.

98a561b

improve the unimplemented message.

47f6bdd

sort our crate declarations

c72039c

Lokathor merged commit fa14304 into main Sep 2, 2024
2 checks passed

Lokathor deleted the clothed branch September 2, 2024 03:18

This was referenced Sep 16, 2024

Setting RUST_IRQ_HANDLER breaks interrupts on real hardware #198

Closed

Push and pop registers in system mode within IRQ handler. #199

Merged

Anders429 mentioned this pull request Oct 9, 2024

Failing on latest nightly Anders429/gba_test#6

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

clothed functions #197

clothed functions #197

Lokathor commented Aug 27, 2024 •

edited

Loading

Anders429 left a comment

clothed functions #197

clothed functions #197

Conversation

Lokathor commented Aug 27, 2024 • edited Loading

Anders429 left a comment

Choose a reason for hiding this comment

Lokathor commented Aug 27, 2024 •

edited

Loading