Update workflow actions to latest #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cecton
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
All good but same comment than mbrman: rust-disk-partition-management/mbrman#28 (comment) I'm not too fan of actions for things that look so simple
We already have the `cargo update` PR to ensure there's a monthly CI run. Removing the timer from the Rust job allows it to be enabled in forks for pre-PR testing without also running it periodically there.
Fix various deprecation warnings. The actions-rs and actions/*release* workflows are unmaintained; replace the former with manual Rust commands and the latter with a substitute. Use generic content type for uploaded artifacts. This avoids the need to run the release step once per artifact, and the content types don't seem to be attached to the final download anyway.
|
Okay, updated! |
bgilbert
merged commit 671b323
into
rust-disk-partition-management:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various deprecation warnings. The
actions-rsandactions/*release*workflows are unmaintained; replace the former with manual Rust commands and the latter with a substitute.Use generic content type for uploaded artifacts. This avoids the need to run the release step once per artifact, and the content types don't seem to be attached to the final download anyway.
Also drop monthly run of Rust workflow. We already have the
cargo updatePR to ensure there's a monthly CI run. Removing the timer from the Rust job allows it to be enabled in forks for pre-PR testing without also running it periodically there.