Add section Embedded Setup back into chapter 5 #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Embedded Setup to SUMMARY - Add 'link-arg' from workspace to 'config.toml' for completeness
BartMassey
requested changes
Jul 31, 2025
There was a problem hiding this comment.
Wow. That's a pretty big omission. Thanks much for catching it!
I don't think we want to change the link arguments in .cargo/config.toml, though: we don't do this with the other chapters, and it has caused problems for people in the past that we're still trying to diagnose and work around.
|
Ok, I've reverted back to the original config.toml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section about embedded setup seems to have fallen out of the book
SUMMARY.mdand is therefore not included in the rendering of the book.The necessary link argument is only specified in the top workspace
.cargo/config.tomland this PR duplicates that line to have a complete reference to include in the chapter.Changes: