Skip to content

Transactional I2C address modes #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Nov 6, 2020

The transactional I2C traits did not support multiple address modes.
Thanks to @ryankurte for noticing this at rust-embedded/linux-embedded-hal#44

@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

@eldruin eldruin force-pushed the transactional-i2c-address-modes branch from 8e06e85 to ba03c1a Compare November 9, 2020 09:51
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bors r+

@bors bors bot merged commit b0d99b5 into rust-embedded:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants