Feature-gate trap-related code in riscv #345
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romancardenas
force-pushed
the
riscv-pac-enum-fix
branch
from
c3e3e55 to
fb73d65
Compare
romancardenas
force-pushed
the
riscv-pac-enum-fix
branch
from
fb73d65 to
73e32c9
Compare
|
This PR is ready for a review. Fixes #344 Fixes rust-embedded/svd2rust#948 (after releasing a new version) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
riscv::pac_enummacro can potentially generate code that refers toriscv-rt. This should be avoided unless explicitly enabled by users.This PR adds the
rtandrt-v-trapfeatures toriscvto fix this bug.Related issues: rust-embedded/svd2rust#948