Merge pull request #836 from rust-embedded/fmt

Debug impl cleanups
rust-embedded · May 6, 2024 · aec3c4f · aec3c4f
2 parents ec223c9 + 305fcd7
commit aec3c4f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/).
 
 ## [Unreleased]
 
+- Remove unneeded `format_args` in register `Debug` impl
+
 ## [v0.33.1] - 2024-04-20
 
 - Add checked `set` for not full safe fields

diff --git a/src/generate/register.rs b/src/generate/register.rs
@@ -476,15 +476,15 @@ fn render_register_mod_debug(
                         let f_name_n = field_accessor(&f.name.expand_dim(&suffix), config, span);
                         let f_name_n_s = format!("{f_name_n}");
                         r_debug_impl.extend(quote! {
-                            .field(#f_name_n_s, &format_args!("{}", self.#f_name_n().#bit_or_bits()))
+                            .field(#f_name_n_s, &self.#f_name_n().#bit_or_bits())
                         });
                     }
                 } else {
                     let f_name = f.name.remove_dim();
                     let f_name = field_accessor(&f_name, config, span);
                     let f_name_s = format!("{f_name}");
                     r_debug_impl.extend(quote! {
-                        .field(#f_name_s, &format_args!("{}", self.#f_name().#bit_or_bits()))
+                        .field(#f_name_s, &self.#f_name().#bit_or_bits())
                     });
                 }
             }