Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Debug for Field/BitReader + generic Debug for Reg #839

Merged
merged 2 commits into from
May 10, 2024
Merged

implement Debug for Field/BitReader + generic Debug for Reg #839

merged 2 commits into from
May 10, 2024

Conversation

burrbull
Copy link
Member

addition for #836

@burrbull burrbull requested a review from a team as a code owner May 10, 2024 08:48
@burrbull
Copy link
Member Author

/ci diff pr

@github-actions GitHub Actions
Copy link

Diff for comment

@burrbull
Copy link
Member Author

/ci diff --current "@pr --impl-debug"

@github-actions GitHub Actions
Copy link

Diff for comment

@burrbull burrbull changed the title implement Debug for Field/BitReader implement Debug for Field/BitReader + generic Debug for Reg May 10, 2024
@burrbull
Copy link
Member Author

burrbull commented May 10, 2024 •
edited
Loading

cc @Emilgardis
How to run ci with --impl-debug flag?

@burrbull
Copy link
Member Author

Let's land this first.

@Emilgardis
Copy link
Member 

/ci diff pr --current " --impl-debug"

@github-actions GitHub Actions
Copy link

Diff for comment

@burrbull
Copy link
Member Author 

/ci diff pr --current " --impl-debug"

Ok. Unsderstood.
But how to enable a flag for both before and after state?

@Emilgardis
Copy link
Member

for both it's just

#/ci diff pr -- --impl-debug

@burrbull
Copy link
Member Author

/ci diff pr -- --impl-debug

@github-actions GitHub Actions
Copy link

Diff for comment

@burrbull burrbull added this pull request to the merge queue May 10, 2024
Merged via the queue into master with commit 959b10e May 10, 2024
46 checks passed
@burrbull burrbull deleted the dbg branch May 10, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @Emilgardis