Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for dead links #1486

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Check for dead links #1486

merged 1 commit into from
Apr 15, 2024

Conversation

janhohenheim
Copy link
Collaborator

Fixes #189

@17cupsofcoffee
Copy link
Collaborator

17cupsofcoffee commented Apr 15, 2024

FYI, Zola has a broken link checker built-in (though it's not super well-documented) - might be worth seeing how well that stacks up against this external one? That would allow it to work on local builds/without extra automation.

EDIT: In fact, it's on by default, so it might be worth trying just the broken link commit on its own to see if Zola catches it!

If that's not a good fit, this sounds like a decent alternative, though 😄

@janhohenheim
Copy link
Collaborator Author

@17cupsofcoffee thanks! I intentionally am not using that because I only want to lint the files touched by the current PR, as no one should have to go over our old newsletters when links break. I don't think Zola supports that, does it?

@janhohenheim
Copy link
Collaborator Author

Thanks @bash for the jq code :)

@janhohenheim
Copy link
Collaborator Author

Done 🎉

@17cupsofcoffee
Copy link
Collaborator

@17cupsofcoffee thanks! I intentionally am not using that because I only want to lint the files touched by the current PR, as no one should have to go over our old newsletters when links break. I don't think Zola supports that, does it?

That makes sense 👍 And no, I don't think Zola supports that.

Co-authored-by: Tau Gärtli <[email protected]>
@janhohenheim
Copy link
Collaborator Author

@17cupsofcoffee I fixed some issues and squashed all of my changes into one clean commit. Could you approve the PR? :)

@janhohenheim janhohenheim merged commit 123efbf into source Apr 15, 2024
1 check passed
@janhohenheim janhohenheim deleted the link-check branch April 15, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Add deadlink checks
3 participants