Skip to content
This repository has been archived by the owner on Jun 1, 2019. It is now read-only.

Some more documentation. #55

Merged
merged 3 commits into from
Jan 30, 2017
Merged

Some more documentation. #55

merged 3 commits into from
Jan 30, 2017

Conversation

maccoda
Copy link
Contributor

@maccoda maccoda commented Jan 28, 2017

Adding some documentation to assist with the set up with diesel, #6

Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small changes 😄

@@ -0,0 +1,12 @@
# Diesel setup
These were the tasks I needed to perform before I could get diesel_cli installed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you put some newlines above and below this line please?

# Diesel setup
These were the tasks I needed to perform before I could get diesel_cli installed.
## Ubunutu
These are the packages referenced in the README that need to be installed for postgresql and sqlite 3:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, above and below. give it a little room to breathe 😄

@maccoda
Copy link
Contributor Author

maccoda commented Jan 28, 2017

Will do 😁

@maccoda
Copy link
Contributor Author

maccoda commented Jan 29, 2017

I also added a link to the instructions from the README, if not desired let me know and can easily change it back 👍

Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a few more tiny things...

@@ -12,7 +12,7 @@ This web application shows people who have contributed to Rust.
You'll need nightly Rust for now. This will change with Rust 1.15, when
this will run on stable.

Get the app set up. You'll need postgres installed. And sqlite3 headers I
Get the app set up. You'll need [postgres](diesel_steup.md) installed. And [sqlite3 headers](diesel_steup.md) I
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you've mis-spelled setup here twice! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 Oh no! Will fix that up!


Then needed to set up postgresql using [this](https://help.ubuntu.com/community/PostgreSQL) tutorial.

After this was able to install diesel_cli and then run the setup with the newly created credentials following the instructions in [README](README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you wrap this to 80 columns please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like all lines wrapped to 80 columns, inclusive of those with links?


## Ubunutu

These are the packages referenced in the README that need to be installed for postgresql and sqlite 3:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you put a newline after this, please?

@steveklabnik steveklabnik merged commit 0a6fb17 into rust-lang-nursery:master Jan 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants