Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

Update atom-ide-rust #194

Merged
merged 6 commits into from
Jun 18, 2021
Merged

Update atom-ide-rust #194

merged 6 commits into from
Jun 18, 2021

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Jun 14, 2021

All the changes from the custom atom-languageclient fork were merged into the official atom-languageclient package (see the details in this issue).

Fixes #175
Fixes #187
Fixes #178

Screenshots

Autocomplete:

image

Datatips:

image

Linter:

image

Outline:
image

@aminya
Copy link
Contributor Author

aminya commented Jun 17, 2021

@alexheretic Could you check this out?

@alexheretic
Copy link
Member

Hey, it's great that you're working on this 👍. However, I'm personally not able to properly review, test or act as maintainer.

I'd offer you the keys to act as maintainer yourself but I don't have that ability.

@aminya
Copy link
Contributor Author

aminya commented Jun 18, 2021

@alexheretic Yes, I can take over the project. I emailed [email protected] a while ago, but it seems no one checks those emails.

@alexheretic
Copy link
Member

I did get an email about that around a month ago. I've sent them a follow up today suggesting they give you the permissions. Perhaps @killercup can help give you the keys?

Me not being able to properly review/test to handover makes this harder so I'm sorry about that.

@killercup
Copy link
Member

Oh no, that was absolutely my bad! I saw your response @alexheretic right before my vacation and then… forgot to follow up 🙈 Very sorry about that!

I don't have admin right on this repo sadly, but I'll immediately find someone who does and can make you a maintainer, @aminya!

@Manishearth Manishearth merged commit b489fa2 into rust-lang:master Jun 18, 2021
@Manishearth
Copy link
Member

Yeah, sorry, we did see the email, but we didn't follow up: the problem was that I'm typically not comfortable handing off maintainership directly without a bit of a ramp up, but since @alexheretic doesn't have time to do that I'm fine doing this. You should have access now.

@aminya
Copy link
Contributor Author

aminya commented Jun 18, 2021

Thanks for all the replies. I will release a new version of the package shortly based on my changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants